Repository navigation
Docs/Test: colour schemes from Python via the ColorScheme constructor (#309) - #315
Merged
Merged
Conversation
…is bound all-required (#309) lightColorScheme / darkColorScheme / ColorScheme.copy have 48 defaulted parameters, past the omission cap, so they bind with every parameter required (a defaults-then-copy strategy was rejected: defaults depend on other parameters, surfaceTint = primary). From Python, ColorScheme(48 args) works and paints its primary through MaterialTheme; copy(primary=...) alone raises 'no value for', copy(all 48) works. SPEC B-3 records it; a keyword factory is pythonx-compose's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
Decision (c), leader-approved:
Tests (ComposableRenderTest):
Results: compose fixture full run, see the checks below. SPEC B-3 is updated. No library or plugin code changes.